Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754737AbbK0P3z (ORCPT ); Fri, 27 Nov 2015 10:29:55 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:34750 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbbK0P3x convert rfc822-to-8bit (ORCPT ); Fri, 27 Nov 2015 10:29:53 -0500 MIME-Version: 1.0 In-Reply-To: <1448637005-3847-1-git-send-email-daniel.vetter@ffwll.ch> References: <1448637005-3847-1-git-send-email-daniel.vetter@ffwll.ch> Date: Fri, 27 Nov 2015 15:29:52 +0000 Message-ID: Subject: Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force From: Emil Velikov To: Daniel Vetter Cc: Intel Graphics Development , LKML , DRI Development , Greg Kroah-Hartman , Andrew Morton Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1807 Lines: 47 On 27 November 2015 at 15:10, Daniel Vetter wrote: > This allows us to ditch a ton of ugly #ifdefs from a bunch of drm modeset > drivers. > > v2: Make the dummy function actually return a sane value, spotted by > Ville. > > Cc: Ville Syrjälä > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/ast/ast_drv.c | 2 -- > drivers/gpu/drm/cirrus/cirrus_drv.c | 2 -- > drivers/gpu/drm/i915/i915_drv.c | 2 -- > drivers/gpu/drm/mgag200/mgag200_drv.c | 2 -- > drivers/gpu/drm/nouveau/nouveau_drm.c | 2 -- > drivers/gpu/drm/qxl/qxl_drv.c | 2 -- > drivers/gpu/drm/radeon/radeon_drv.c | 2 -- > include/linux/console.h | 2 ++ The new drivers seems to be missing the conversion. Namely amdgpu and virtio_gpu. > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -1072,10 +1072,8 @@ nouveau_drm_init(void) > nouveau_display_options(); > > if (nouveau_modeset == -1) { > -#ifdef CONFIG_VGA_CONSOLE > if (vgacon_text_force()) > nouveau_modeset = 0; > -#endif It's kind of interesting how nouveau differs from everyone else. The force toggle has lower priority than the nouveau specific one :-) Obviously not something you should address or anything. Another interesting fact is how none of the SoC honour the modeset fla :-\ Regards, Emil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/