Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755139AbbK0RYm (ORCPT ); Fri, 27 Nov 2015 12:24:42 -0500 Received: from mga11.intel.com ([192.55.52.93]:14654 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754839AbbK0RYj convert rfc822-to-8bit (ORCPT ); Fri, 27 Nov 2015 12:24:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,352,1444719600"; d="scan'208";a="848470455" From: "Tirdea, Irina" To: Rob Herring , Dmitry Torokhov CC: Bastien Nocera , Aleksei Mamlin , Karsten Merker , "linux-input@vger.kernel.org" , Mark Rutland , "Purdila, Octavian" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH v11 6/8] Input: goodix - add support for ESD Thread-Topic: [PATCH v11 6/8] Input: goodix - add support for ESD Thread-Index: AQHRI6qCLwwM1PUTzU+hf6kJjD/X256wJ9hg Date: Fri, 27 Nov 2015 17:24:21 +0000 Deferred-Delivery: Fri, 27 Nov 2015 17:24:00 +0000 Message-ID: <1F3AC3675D538145B1661F571FE1805F2F1265D3@irsmsx105.ger.corp.intel.com> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-7-git-send-email-irina.tirdea@intel.com> <20151120154458.GA12090@rob-hp-laptop> In-Reply-To: <20151120154458.GA12090@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 48 > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 20 November, 2015 17:45 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD > > On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: > > Add ESD (Electrostatic Discharge) protection mechanism. > > [...] > > > This is based on Goodix datasheets for GT911 and GT9271 and on Goodix > > driver gt9xx.c for Android (publicly available in Android kernel > > trees for various devices). > > > > Signed-off-by: Irina Tirdea > > For the binding: Acked-by: Rob Herring > > You should not have the "For the binding:" part here. It was just a note > so it was clear what part I looked at. > I saw it done like that in another patch already merged, so I thought it's the right way [1]. Dmitry, could you fix this at merge or you need me to send another patchset? Thanks, Irina [1] https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/commit/?id=d2a3e0931a8f3b95b910096d022ffd98adbd075c > It is preferred to split DT bindings to separate patches for this > reason. > > > Signed-off-by: Irina Tirdea > > --- > > .../bindings/input/touchscreen/goodix.txt | 4 + > > drivers/input/touchscreen/goodix.c | 160 ++++++++++++++++++++- > > 2 files changed, 159 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/