Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755174AbbK0R2g (ORCPT ); Fri, 27 Nov 2015 12:28:36 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33156 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796AbbK0R2b (ORCPT ); Fri, 27 Nov 2015 12:28:31 -0500 Date: Fri, 27 Nov 2015 09:28:27 -0800 From: Dmitry Torokhov To: "Tirdea, Irina" Cc: Rob Herring , Bastien Nocera , Aleksei Mamlin , Karsten Merker , "linux-input@vger.kernel.org" , Mark Rutland , "Purdila, Octavian" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD Message-ID: <20151127172827.GA27040@dtor-ws> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-7-git-send-email-irina.tirdea@intel.com> <20151120154458.GA12090@rob-hp-laptop> <1F3AC3675D538145B1661F571FE1805F2F1265D3@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1F3AC3675D538145B1661F571FE1805F2F1265D3@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 43 On Fri, Nov 27, 2015 at 05:24:21PM +0000, Tirdea, Irina wrote: > > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: 20 November, 2015 17:45 > > To: Tirdea, Irina > > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; > > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org > > Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD > > > > On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: > > > Add ESD (Electrostatic Discharge) protection mechanism. > > > > [...] > > > > > This is based on Goodix datasheets for GT911 and GT9271 and on Goodix > > > driver gt9xx.c for Android (publicly available in Android kernel > > > trees for various devices). > > > > > > Signed-off-by: Irina Tirdea > > > For the binding: Acked-by: Rob Herring > > > > You should not have the "For the binding:" part here. It was just a note > > so it was clear what part I looked at. > > > > I saw it done like that in another patch already merged, so I thought it's > the right way [1]. Dmitry, could you fix this at merge or you need me to > send another patchset? No, I can fix it up locally. Let me sort through the latest submission and I'll let you know if I need any changes. Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/