Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754823AbbK0Tlh (ORCPT ); Fri, 27 Nov 2015 14:41:37 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:32946 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbbK0Tld (ORCPT ); Fri, 27 Nov 2015 14:41:33 -0500 Message-ID: <5658B1E9.2010700@bjorling.me> Date: Fri, 27 Nov 2015 20:41:29 +0100 From: =?UTF-8?B?TWF0aWFzIEJqw7hybGluZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Wenwei Tao CC: keith.busch@intel.com, axboe@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2 1/3] lightnvm: missing nvm_lock acquire References: <1448597384-27976-1-git-send-email-ww.tao0320@gmail.com> <1448597384-27976-2-git-send-email-ww.tao0320@gmail.com> <565814E8.9020408@bjorling.me> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 18 On 11/27/2015 01:04 PM, Wenwei Tao wrote: > Hi Matias > Previous version patch miss acquire lock before find supported manager > in nvm_init(). > And find supported manager code is duplicated in nvm_init() and > nvm_create_target(), we may move it into a function to make the code > more clean. > And find supported manager may blocked while holding the lock, this is > not good. > Ok, thanks. I'll pick this one up instead then. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/