MIME-Version: 1.0
In-Reply-To: <56589E48.9000708@google.com>
References: <1448481582-16991-1-git-send-email-jinqian@android.com>
 <20151125202416.GA4636@rob-hp-laptop> <20151126083412.GB14945@lvm> <56589E48.9000708@google.com>
From: Rob Herring <robh@kernel.org>
Date: Fri, 27 Nov 2015 14:14:03 -0600
Message-ID: <CAL_JsqLf1hQjw=SnnF4B0jFT18DsugeTXfJ1oGio5NVsepm-ug@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] platform: goldfish: pipe: add devicetree bindings
To: Greg Hackmann <ghackmann@google.com>
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
        Jin Qian <jinqian@android.com>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joe Perches <joe@perches.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Peter Senna Tschudin <peter.senna@gmail.com>,
        =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1417
Lines: 36

On Fri, Nov 27, 2015 at 12:17 PM, Greg Hackmann <ghackmann@google.com> wrote:
> On 11/26/15 12:34 AM, Christoffer Dall wrote:
>>
>> On Wed, Nov 25, 2015 at 02:24:16PM -0600, Rob Herring wrote:
>>>
>>>
>>> The binding may be trivial, but there's a bigger question of whether
>>> this is the right long term direction. For example is upstream QEMU
>>> going to take all the Android pipe stuff? Couldn't virtio be used here
>>> as the transport?
>>>
>>
>> But I wonder if that should really block this from being merged?  The
>> support may not be in QEMU but it's in the Android emulator and it would
>> be a less broken implementation with these patches in the kernel than
>> without, I think.
>>
>> -Christoffer
>>
>
> To add to Christoffer's point, we added these bindings so we don't need to
> rely on the goldfish virtual bus for probing anymore.
>
> Switching from the goldfish virtual bus to Device-Tree already eliminates
> one big piece where the Android emulator has diverged from upstream qemu.
> And on the kernel side, it means we don't need ARM and MIPS goldfish board
> code to instantiate the bus.

Okay, fair enough. That's not evident from the patch.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/