From: Arnd Bergmann <arnd@arndb.de>
To: Ray Jui <rjui@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Marc Zyngier <marc.zyngier@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support
Date: Fri, 27 Nov 2015 21:22:21 +0100
Message-ID: <2502233.oJMLi3GpfH@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1448645868-5730-3-git-send-email-rjui@broadcom.com>
References: <1448645868-5730-1-git-send-email-rjui@broadcom.com> <1448645868-5730-3-git-send-email-rjui@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 984
Lines: 26

On Friday 27 November 2015 09:37:45 Ray Jui wrote:
> 
> +static const struct of_device_id iproc_pcie_of_match_table[] = {
> +       {
> +               .compatible = "brcm,iproc-pcie",
> +               .data = (int *)IPROC_PCIE_PAXB,
> +       }, {
> +               .compatible = "brcm,iproc-pcie-paxc",
> +               .data = (int *)IPROC_PCIE_PAXC,
> +       },
> +       { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, iproc_pcie_of_match_table);

You seem to only need the identifiers in order to set a single
pointer, so just point to that array directly. Alternatively,
do the more common thing and point to a structure of function
pointers and have different implementations of the low-level
access functions there.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/