Subject: Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support
To: Arnd Bergmann <arnd@arndb.de>
References: <1448645868-5730-1-git-send-email-rjui@broadcom.com>
 <2502233.oJMLi3GpfH@wuerfel> <5658C365.5080209@broadcom.com>
 <3529525.ts0Jjxrtm5@wuerfel>
CC: Bjorn Helgaas <bhelgaas@google.com>, Marc Zyngier <marc.zyngier@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, <linux-kernel@vger.kernel.org>,
        <bcm-kernel-feedback-list@broadcom.com>, <linux-pci@vger.kernel.org>
From: Ray Jui <rjui@broadcom.com>
Message-ID: <5658C897.4090002@broadcom.com>
Date: Fri, 27 Nov 2015 13:18:15 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <3529525.ts0Jjxrtm5@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1535
Lines: 41

Hi Arnd,

On 11/27/2015 1:11 PM, Arnd Bergmann wrote:
> On Friday 27 November 2015 12:56:05 Ray Jui wrote:
>>>
>>> You seem to only need the identifiers in order to set a single
>>> pointer, so just point to that array directly.
>>
>> Not just a single pointer. This sets the iProc PCIe interface type,
>> which is an enum. Based on the interface type, both the iProc PCIe core
>> driver and the iProc PCIe MSI driver can 1) load the correct set of
>> register offsets; 2) skip/invoke some of the link detection, controller
>> reset related behaviors; 3) setting up the correct number of MSI event
>> queue regions and MSI address regions.
>
> Ok, fair enough. I had missed 2) and 3) here. It could still be done
> as a structure (rather than function pointers) with individual named
> members for each register offset along with bool flags for 2) and
> integers to describe 3).
>
> Please that suggestion some thought, and then decide for yourself,
> I won't complain if you keep the current version.
>
> 	Arnd
>

I'll definitely re-visit this when I need to add support to the next 
revision of PAXC interface. At that time, what you have suggested may 
become almost mandatory in order to make the core code clean and more 
maintainable.

For now, I'll keep this as it is.

Thanks!

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/