Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755434AbbK0Vbk (ORCPT ); Fri, 27 Nov 2015 16:31:40 -0500 Received: from mailrelay119.isp.belgacom.be ([195.238.20.146]:2817 "EHLO mailrelay119.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755484AbbK0V36 (ORCPT ); Fri, 27 Nov 2015 16:29:58 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2B/AgC5ylhW/6YUtFtWCIJpUoFCvAWCGgENgWSGDwKBPjkUAQEBAQEBAYEKhDUBAQQnLyMQUTkeGYgyAbJwig4BAQEHI4ZUiSYOcYQSBZZXjTiPMY0wHwEBQoIRHYFXPTSECIFKAQEB From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: Philipp Reisner , Fabian Frederick , Lars Ellenberg , drbd-dev@lists.linbit.com Subject: [PATCH 16/21] drbd: fix maybe_pull_ahead() locking comments Date: Fri, 27 Nov 2015 22:29:31 +0100 Message-Id: <1448659775-13596-7-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1448659775-13596-1-git-send-email-fabf@skynet.be> References: <1448659575-13485-1-git-send-email-fabf@skynet.be> <1448659775-13596-1-git-send-email-fabf@skynet.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 29 maybe_pull_ahead() calls rcu_read_lock() itself and is only called within req_lock (locked by drbd_send_and_submit() Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 2255dcf..2228012 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -995,7 +995,7 @@ static void complete_conflicting_writes(struct drbd_request *req) finish_wait(&device->misc_wait, &wait); } -/* called within req_lock and rcu_read_lock() */ +/* called within req_lock */ static void maybe_pull_ahead(struct drbd_device *device) { struct drbd_connection *connection = first_peer_device(device)->connection; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/