From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>, Jens Axboe <axboe@fb.com>,
        Matias Bjorling <m@bjorling.me>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] null_blk: use sector_div instead of do_div
Date: Fri, 27 Nov 2015 22:31:26 +0100
Message-ID: <4449032.oPBtpzlXyB@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CA+55aFy=JjwmtNysByu822S2Av0sv_KUCLfa86tAz5K5Unwsmw@mail.gmail.com>
References: <3768541.ja0r6f0Odi@wuerfel> <CA+55aFy=JjwmtNysByu822S2Av0sv_KUCLfa86tAz5K5Unwsmw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2151
Lines: 52

On Friday 27 November 2015 10:07:54 Linus Torvalds wrote:
> On Fri, Nov 27, 2015 at 5:49 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > -       do_div(size, bs); /* convert size to pages */
> > -       do_div(size, 256); /* concert size to pgs pr blk */
> > +       sector_div(size, bs); /* convert size to pages */
> > +       sector_div(size, 256); /* concert size to pgs pr blk */
> 
> Ugh.
> 
> Dividing by 256 should never be done with do_div() *or* sector-div.

You are right, I missed what should have been an obvious simplification.
FWIW, the division by 256 should now be optimized automatically when the
new asm-generic do_div() implementation is used (which in turn caused
the type mismatch warning that I'm trying to avoid). Of course that
is no excuse for writing silly code like that, and it doesn't catch the
cases where the argument is a power-of-two variable number.

The first do_div() is also questionable: 'bs' is a global variable
from a module parameter that defaults to 512 and is fixed to 4096
when the device is used for lightnvm. I would guess that we run into
bugs if this is ever set to a number that is not a power of two,
smaller than 512, or larger than PAGE_SIZE.

> Same goes for this, which is just obnoxiously idiotic:
> 
> > -       do_div(size, (1 << 16));
> > +       sector_div(size, (1 << 16));
> 
> WTF? It explicitly divides by a particular power-of-two?
> 
> Has nobody ever heard of expensive divide operations? Sure, for the
> cases where we *don't* do this with inline asm etc because it's
> already fairly cheap, the compiler will DTRT. But that "divide by (1
> << 16)" is just a sign of insanity.
> 
> Why is that not just
> 
>     size >>= 16;
> 
> instead, which is certainly not any less legible, and won't generate
> potentially crap code?

I'll wait for Matias or Jens to comment on the blocksize, but can
do a new patch unless they beat me to it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/