Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751545AbbK0Wdr (ORCPT ); Fri, 27 Nov 2015 17:33:47 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34661 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbbK0Wdo (ORCPT ); Fri, 27 Nov 2015 17:33:44 -0500 Date: Fri, 27 Nov 2015 14:33:40 -0800 From: Brian Norris To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: "linux-mtd@lists.infradead.org" , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition Message-ID: <20151127223340.GB19615@localhost> References: <1448525104-20101-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 30 On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote: > On 26 November 2015 at 09:05, Rafał Miłecki wrote: > > So far struct spi_nor was using just a pointer to struct mtd_info so it > > wasn't needed to have it fully defined there. After recent change we > > embed whole struct so we need to include a proper header. Good catch. > > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor") I'm not 100% sure, but I thought I recall the -stable folks picking up for-linus commits just based on the 'Fixes:' tags. I feel like that isn't always ideal, though. > > Signed-off-by: Rafał Miłecki > > This may be worth taking as a fix for 4.4. However I'm not aware of > any upstream driver failing to build because of this. I don't see why it would need rushed out. All users of spi-nor.h currently include mtd.h first. So there are no build failures because of it. Regards, Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/