Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751570AbbK1BoZ (ORCPT ); Fri, 27 Nov 2015 20:44:25 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:33989 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbbK1BoU convert rfc822-to-8bit (ORCPT ); Fri, 27 Nov 2015 20:44:20 -0500 MIME-Version: 1.0 In-Reply-To: <5658B1E9.2010700@bjorling.me> References: <1448597384-27976-1-git-send-email-ww.tao0320@gmail.com> <1448597384-27976-2-git-send-email-ww.tao0320@gmail.com> <565814E8.9020408@bjorling.me> <5658B1E9.2010700@bjorling.me> Date: Sat, 28 Nov 2015 09:44:20 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] lightnvm: missing nvm_lock acquire From: Wenwei Tao To: =?UTF-8?Q?Matias_Bj=C3=B8rling?= Cc: keith.busch@intel.com, axboe@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 25 Hi Matiasl Just to let you know this patch and previous version both cannot address 'register device with supported manager may blocked while holding the lock' issue. 2015-11-28 3:41 GMT+08:00 Matias Bjørling : > On 11/27/2015 01:04 PM, Wenwei Tao wrote: >> >> Hi Matias >> Previous version patch miss acquire lock before find supported manager >> in nvm_init(). >> And find supported manager code is duplicated in nvm_init() and >> nvm_create_target(), we may move it into a function to make the code >> more clean. >> And find supported manager may blocked while holding the lock, this is >> not good. >> > > Ok, thanks. I'll pick this one up instead then. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/