Subject: Re: [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and
 cgroup_migrate()
To: Oleg Nesterov <oleg@redhat.com>, Aleksa Sarai <cyphar@cyphar.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>
References: <20151127185705.GA14669@redhat.com>
CC: <linux-kernel@vger.kernel.org>
From: Zefan Li <lizefan@huawei.com>
Message-ID: <56591AED.7050808@huawei.com>
Date: Sat, 28 Nov 2015 11:09:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20151127185705.GA14669@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 36

On 2015/11/28 2:57, Oleg Nesterov wrote:
> On 11/26, Oleg Nesterov wrote:
>>
>> OK. I do not know what exactly do you mean, perhaps if you fix this problem
>> the race between fork and attach goes away and in this case the fix I sent
>> is not needed?
>
> Otherwise please consider this series.
>
> Slightly tested, seems to work; please review.
>

Allowing tasks migrating between cgroups while forking is problematic. I'm more
than glad to see those changes.

Acked-by: Zefan Li <lizefan@huawei.com>

> Oleg.
>
>   include/linux/cgroup-defs.h   |   12 ++------
>   include/linux/cgroup.h        |   19 ++++---------
>   include/linux/cgroup_subsys.h |   18 ------------
>   kernel/cgroup.c               |   30 +++++----------------
>   kernel/cgroup_freezer.c       |    2 +-
>   kernel/cgroup_pids.c          |   58 +++++++---------------------------------
>   kernel/fork.c                 |   16 ++++-------
>   kernel/sched/core.c           |    2 +-
>   8 files changed, 34 insertions(+), 123 deletions(-)
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/