Subject: Re: [PATCH 1/3] usb: musb: convert printk to pr_*
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <1448620703-13101-1-git-send-email-linux@rasmusvillemoes.dk>
 <56584B45.8000601@cogentembedded.com> <20151128000432.GA22297@kroah.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, Felipe Balbi <balbi@ti.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <5659803B.60807@cogentembedded.com>
Date: Sat, 28 Nov 2015 13:21:47 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151128000432.GA22297@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 881
Lines: 26

On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote:

>>> This file already uses pr_debug in a few places; this converts the
>>> remaining printks.
>>
>>     Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent?
>
> Yes, and that is a good thing, you should be using pr_debug() instead of
> printk(KERN_DEBUG...).
>
> Why object to something like this?

    I'm not objecting, just asking. There have been many cases in my practice 
where a patch author wasn't aware of that...
    It's just that these printk()'s could have been intentional (not to depend 
on DEBUG or dynamic debugging).

> greg k-h

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/