Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbbK1OF3 (ORCPT ); Sat, 28 Nov 2015 09:05:29 -0500 Received: from mail-ig0-f180.google.com ([209.85.213.180]:34876 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbbK1OF0 convert rfc822-to-8bit (ORCPT ); Sat, 28 Nov 2015 09:05:26 -0500 MIME-Version: 1.0 In-Reply-To: <20151127223340.GB19615@localhost> References: <1448525104-20101-1-git-send-email-zajec5@gmail.com> <20151127223340.GB19615@localhost> Date: Sat, 28 Nov 2015 15:05:26 +0100 Message-ID: Subject: Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Brian Norris Cc: "linux-mtd@lists.infradead.org" , Linux Kernel Mailing List , Stable Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1475 Lines: 35 On 27 November 2015 at 23:33, Brian Norris wrote: > On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote: >> On 26 November 2015 at 09:05, Rafał Miłecki wrote: >> > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor") > > I'm not 100% sure, but I thought I recall the -stable folks picking up > for-linus commits just based on the 'Fixes:' tags. I feel like that > isn't always ideal, though. I'm confused. Do you mean I shouldn't include it? Do you have a reference to more detailed Fixes usage? All I found is info in Documentation/SubmittingPatches: > If your patch fixes a bug in a specific commit, e.g. you found an issue using > git-bisect, please use the 'Fixes:' tag I think 'Fixes' usage is OK in this case. >> > Signed-off-by: Rafał Miłecki >> >> This may be worth taking as a fix for 4.4. However I'm not aware of >> any upstream driver failing to build because of this. > > I don't see why it would need rushed out. All users of spi-nor.h > currently include mtd.h first. So there are no build failures because of > it. OK. It was just an OpenWrt out-of-tree driver that failed to compile. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/