Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbK1RAs (ORCPT ); Sat, 28 Nov 2015 12:00:48 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:43541 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbbK1RAq (ORCPT ); Sat, 28 Nov 2015 12:00:46 -0500 Date: Sat, 28 Nov 2015 18:00:36 +0100 From: Andrew Lunn To: Sebastian Hesselbarth Cc: Jason Cooper , Gregory Clement , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Benoit Masson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Message-ID: <20151128170036.GH32356@lunn.ch> References: <1448709248-21177-1-git-send-email-sebastian.hesselbarth@gmail.com> <1448709248-21177-3-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448709248-21177-3-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3739 Lines: 131 On Sat, Nov 28, 2015 at 12:14:06PM +0100, Sebastian Hesselbarth wrote: > NAND flash partitions should be part of a partitions sub-node > not the flash node itself. Move the partitions which will also > allow different bootloaders get rid of the stock partitions > easily by removing the partitions node. > > Signed-off-by: Sebastian Hesselbarth Humm, did not know that. Quoting Documentation/devicetree/bindings/mtd/partition.txt: The partition table should be a subnode of the mtd node and should be named 'partitions'. Partitions are defined in subnodes of the partitions node. For backwards compatibility partitions as direct subnodes of the mtd device are supported. This use is discouraged. It also looks like none of the other MVEBU maintainers know that either, since a quick look at the .dts files shows very few have a partitions node. Acked-by: Andrew Lunn Thanks Andrew > --- > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: Russell King > Cc: Benoit Masson > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 67 +++++++++++++------------ > 1 file changed, 36 insertions(+), 31 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > index 30a0a6eac645..76781fd18624 100644 > --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > @@ -151,37 +151,42 @@ > marvell,nand-enable-arbiter; > nand-on-flash-bbt; > > - partition@0 { > - label = "u-boot"; > - reg = <0x0000000 0xe0000>; > - read-only; > - }; > - > - partition@e0000 { > - label = "u-boot-env"; > - reg = <0xe0000 0x20000>; > - read-only; > - }; > - > - partition@100000 { > - label = "u-boot-env2"; > - reg = <0x100000 0x20000>; > - read-only; > - }; > - > - partition@120000 { > - label = "zImage"; > - reg = <0x120000 0x400000>; > - }; > - > - partition@520000 { > - label = "initrd"; > - reg = <0x520000 0x400000>; > - }; > - > - partition@xE00000 { > - label = "boot"; > - reg = <0xE00000 0x3F200000>; > + partitions { > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@0 { > + label = "u-boot"; > + reg = <0x0000000 0xe0000>; > + read-only; > + }; > + > + partition@e0000 { > + label = "u-boot-env"; > + reg = <0xe0000 0x20000>; > + read-only; > + }; > + > + partition@100000 { > + label = "u-boot-env2"; > + reg = <0x100000 0x20000>; > + read-only; > + }; > + > + partition@120000 { > + label = "zImage"; > + reg = <0x120000 0x400000>; > + }; > + > + partition@520000 { > + label = "initrd"; > + reg = <0x520000 0x400000>; > + }; > + > + partition@xE00000 { > + label = "boot"; > + reg = <0xE00000 0x3F200000>; > + }; > }; > }; > }; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/