Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbbK1Rid (ORCPT ); Sat, 28 Nov 2015 12:38:33 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36155 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbbK1Ria (ORCPT ); Sat, 28 Nov 2015 12:38:30 -0500 From: Sebastian Hesselbarth Subject: Re: [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node To: Andrew Lunn References: <1448709248-21177-1-git-send-email-sebastian.hesselbarth@gmail.com> <1448709248-21177-3-git-send-email-sebastian.hesselbarth@gmail.com> <20151128170036.GH32356@lunn.ch> Cc: Jason Cooper , Gregory Clement , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Benoit Masson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5659E692.9040007@gmail.com> Date: Sat, 28 Nov 2015 18:38:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <20151128170036.GH32356@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4277 Lines: 145 On 28.11.2015 18:00, Andrew Lunn wrote: > On Sat, Nov 28, 2015 at 12:14:06PM +0100, Sebastian Hesselbarth wrote: >> NAND flash partitions should be part of a partitions sub-node >> not the flash node itself. Move the partitions which will also >> allow different bootloaders get rid of the stock partitions >> easily by removing the partitions node. >> >> Signed-off-by: Sebastian Hesselbarth > > Humm, did not know that. Quoting Documentation/devicetree/bindings/mtd/partition.txt: > > The partition table should be a subnode of the mtd node and > should be named 'partitions'. Partitions are defined in subnodes > of the partitions node. > > For backwards compatibility partitions as direct subnodes of the > mtd device are supported. This use is discouraged. > > It also looks like none of the other MVEBU maintainers know that > either, since a quick look at the .dts files shows very few have a > partitions node. Me neither, Linus Walleij's latest contribution to the pogoplug series showed it to me. And while I am working on barebox support for the ix4, I always wanted to remove the stock partitions easily. Barebox always uses internal registers at 0xf1000000 so it will never boot that stupid stock kernel that depends on 0xd0000000 registers. > Acked-by: Andrew Lunn > > Thanks > Andrew ditto ;) Sebastian >> --- >> Cc: Jason Cooper >> Cc: Andrew Lunn >> Cc: Gregory Clement >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> Cc: Russell King >> Cc: Benoit Masson >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> --- >> arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 67 +++++++++++++------------ >> 1 file changed, 36 insertions(+), 31 deletions(-) >> >> diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts >> index 30a0a6eac645..76781fd18624 100644 >> --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts >> +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts >> @@ -151,37 +151,42 @@ >> marvell,nand-enable-arbiter; >> nand-on-flash-bbt; >> >> - partition@0 { >> - label = "u-boot"; >> - reg = <0x0000000 0xe0000>; >> - read-only; >> - }; >> - >> - partition@e0000 { >> - label = "u-boot-env"; >> - reg = <0xe0000 0x20000>; >> - read-only; >> - }; >> - >> - partition@100000 { >> - label = "u-boot-env2"; >> - reg = <0x100000 0x20000>; >> - read-only; >> - }; >> - >> - partition@120000 { >> - label = "zImage"; >> - reg = <0x120000 0x400000>; >> - }; >> - >> - partition@520000 { >> - label = "initrd"; >> - reg = <0x520000 0x400000>; >> - }; >> - >> - partition@xE00000 { >> - label = "boot"; >> - reg = <0xE00000 0x3F200000>; >> + partitions { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + partition@0 { >> + label = "u-boot"; >> + reg = <0x0000000 0xe0000>; >> + read-only; >> + }; >> + >> + partition@e0000 { >> + label = "u-boot-env"; >> + reg = <0xe0000 0x20000>; >> + read-only; >> + }; >> + >> + partition@100000 { >> + label = "u-boot-env2"; >> + reg = <0x100000 0x20000>; >> + read-only; >> + }; >> + >> + partition@120000 { >> + label = "zImage"; >> + reg = <0x120000 0x400000>; >> + }; >> + >> + partition@520000 { >> + label = "initrd"; >> + reg = <0x520000 0x400000>; >> + }; >> + >> + partition@xE00000 { >> + label = "boot"; >> + reg = <0xE00000 0x3F200000>; >> + }; >> }; >> }; >> }; >> -- >> 2.1.4 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/