Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836AbbK2MtJ (ORCPT ); Sun, 29 Nov 2015 07:49:09 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38585 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbbK2MtH (ORCPT ); Sun, 29 Nov 2015 07:49:07 -0500 Date: Sun, 29 Nov 2015 13:49:03 +0100 From: Daniel Vetter To: Emil Velikov Cc: Daniel Vetter , Intel Graphics Development , LKML , DRI Development , Greg Kroah-Hartman , Andrew Morton Subject: Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force Message-ID: <20151129124903.GB17050@phenom.ffwll.local> Mail-Followup-To: Emil Velikov , Intel Graphics Development , LKML , DRI Development , Greg Kroah-Hartman , Andrew Morton References: <1448637005-3847-1-git-send-email-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 40 On Fri, Nov 27, 2015 at 03:29:52PM +0000, Emil Velikov wrote: > On 27 November 2015 at 15:10, Daniel Vetter wrote: > > This allows us to ditch a ton of ugly #ifdefs from a bunch of drm modeset > > drivers. > > > > v2: Make the dummy function actually return a sane value, spotted by > > Ville. > > > > Cc: Ville Syrj?l? > > Cc: Andrew Morton > > Cc: Greg Kroah-Hartman > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/ast/ast_drv.c | 2 -- > > drivers/gpu/drm/cirrus/cirrus_drv.c | 2 -- > > drivers/gpu/drm/i915/i915_drv.c | 2 -- > > drivers/gpu/drm/mgag200/mgag200_drv.c | 2 -- > > drivers/gpu/drm/nouveau/nouveau_drm.c | 2 -- > > drivers/gpu/drm/qxl/qxl_drv.c | 2 -- > > drivers/gpu/drm/radeon/radeon_drv.c | 2 -- > > include/linux/console.h | 2 ++ > > The new drivers seems to be missing the conversion. Namely amdgpu and > virtio_gpu. Just shows how old this patch is ;-) And it's not going to cause a problem since this patch simply makes the #ifdef redundant. Greg, do you prefer a respin or a fixup patch? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/