Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbbK2Pno (ORCPT ); Sun, 29 Nov 2015 10:43:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:33159 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbbK2Pnl (ORCPT ); Sun, 29 Nov 2015 10:43:41 -0500 Subject: Re: block: Always check queue limits for cloned requests To: Markus Trippelsdorf , Mike Snitzer References: <1448524017-130967-1-git-send-email-hare@suse.de> <20151126131104.GA24297@redhat.com> <20151129114956.GA321@x4> Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig , "Martin K. Petersen" , Ewan Milne , Jeff Moyer From: Hannes Reinecke Message-ID: <565B1D2A.5010603@suse.de> Date: Sun, 29 Nov 2015 16:43:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151129114956.GA321@x4> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1987 Lines: 53 On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote: >> On Thu, Nov 26 2015 at 2:46am -0500, >> Hannes Reinecke wrote: >> >>> When a cloned request is retried on other queues it always needs >>> to be checked against the queue limits of that queue. >>> Otherwise the calculations for nr_phys_segments might be wrong, >>> leading to a crash in scsi_init_sgtable(). >>> >>> To clarify this the patch renames blk_rq_check_limits() >>> to blk_cloned_rq_check_limits() and removes the symbol >>> export, as the new function should only be used for >>> cloned requests and never exported. >>> >>> Cc: Mike Snitzer >>> Cc: Ewan Milne >>> Cc: Jeff Moyer >>> Signed-off-by: Hannes Reinecke >> >> Patch looks good. Thanks for getting to the bottom of this. >> >> Jens, please add these extra tags when you pick this up: >> >> Fixes: e2a60da74 ("block: Clean up special command handling logic") >> Cc: stable@vger.kernel.org # 3.7+ >> Acked-by: Mike Snitzer > > I'm still seeing the issue (BUG at drivers/scsi/scsi_lib.c:1096!) even > with this patch applied. > > markus@x4 linux % git describe > v4.4-rc2-215-g081f3698e606 > Can you generate a crashdump? I would need to cross-check with the other dumps I'm having to figure out if this really is the same issue. There have been other reports (and fixes) which show we're fighting several distinct issues here. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/