Subject: Re: [radeon r100] when ring test fails, provide users with option to
 test
To: Pavel Machek <pavel@ucw.cz>, Trivial patch monkey <trivial@kernel.org>,
        <alexander.deucher@amd.com>, <airlied@linux.ie>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
References: <20151128205840.GA26757@amd>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <565B56A5.4080702@amd.com>
Date: Sun, 29 Nov 2015 20:48:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151128205840.GA26757@amd>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2015 19:49:07.0721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0134
X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0073;2:dXAPamdYY+SiR2hJIWPT9qeYclmmVRCK1TZUe8oWibz/nZEtBnGhCFXjjnOLiwZ/kF3iSoOgxQaPUH9LOPs5+e7152O7Stiilw8npFj0QTIpMaxnkaQ+GW+qkN4gC68YZmkeZolic3VDuuEmg3v4dg==;23:QX42g0w6UwkeXWaSdDbbWc2C6vVLSTV50aBWjBS0KvELq8Spf04c5LYRkBLvsXWCL8D9lEVE1kHbCCc+CvvqY+dhSFnMdufgirj7QDY0ooSAKZv3DjsWG6vi9oDzF5DauP1pALF49bsouuv2l5OXcP049mD+BARMz+VKqTTCpVXBtcCj/3Kh9VENHzkkSuuS
X-OriginatorOrg: amd.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1163
Lines: 33

On 28.11.2015 21:58, Pavel Machek wrote:
> Ring test failure is often caused by too high agpmode. Tell the user
> what to try.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

NAK, the ring test can fail for any number of reasons and the agpmode is 
actually rather unlikely to be the cause.

Regards,
Christian.

>
> diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
> index 238b13f..32b1917 100644
> --- a/drivers/gpu/drm/radeon/r100.c
> +++ b/drivers/gpu/drm/radeon/r100.c
> @@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
>   	if (i < rdev->usec_timeout) {
>   		DRM_INFO("ring test succeeded in %d usecs\n", i);
>   	} else {
> -		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
> +		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
>   			  scratch, tmp);
>   		r = -EINVAL;
>   	}
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/