Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbbK3Cc2 (ORCPT ); Sun, 29 Nov 2015 21:32:28 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36833 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbbK3CcY (ORCPT ); Sun, 29 Nov 2015 21:32:24 -0500 Subject: Re: [PATCH v1 1/5] thermal: rockchip: fix a trivial typo To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1448592746-2129-1-git-send-email-wxt@rock-chips.com> <1448592746-2129-2-git-send-email-wxt@rock-chips.com> <5259912.5mmETGszQg@diego> Cc: Eduardo Valentin , linux-rockchip@lists.infradead.org, Dan Carpenter , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Zhang Rui , linux-arm-kernel@lists.infradead.org From: Caesar Wang Message-ID: <565BB532.4010804@gmail.com> Date: Mon, 30 Nov 2015 10:32:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5259912.5mmETGszQg@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2283 Lines: 76 Hi Heiko, Thanks to take your time to review that. 在 2015年11月27日 17:49, Heiko Stübner 写道: > Hi Caesar, > > Am Freitag, 27. November 2015, 10:52:22 schrieb Caesar Wang: [...] > > /** > -* The conversion table has the adc value and temperature. > -* ADC_DECREMENT is the adc value decremnet.(e.g. v2_code_table) > -* ADC_INCREMNET is the adc value incremnet.(e.g. v3_code_table) > -*/ > + * The conversion table has the adc value and temperature. > + * ADC_DECREMENT: the adc value is of diminishing.(e.g. v2_code_table) > + * ADC_INCREMENT: the adc value is incremental.(e.g. v3_code_table) > + */ > enum adc_sort_mode { > ADC_DECREMENT = 0, > ADC_INCREMENT, > @@ -75,13 +75,13 @@ enum adc_sort_mode { > You could simply move to documenting the fields in the header (like > exynos_tmu.c for example) instead of inside the table. I think there are even > tools that create documention from these comments, so I'd suggest: > > /* > * struct chip_tsadc_table: hold information about chip-specific differences > * @id: conversion table > * @length: size of conversion table > * @data_mask: mask to apply on data inputs > * @mode: sort mode of this adc variant (incrementing or decrementing) > */ That's a good idea for this. Fixed in next patch v2. >> struct chip_tsadc_table { >> const struct tsadc_table *id; >> >> - /* the array table size*/ >> + /* The array table size */ >> unsigned int length; >> >> - /* that analogic mask data */ >> + /* That analogic mask data */ >> u32 data_mask; >> >> - /* the sort mode is adc value that increment or decrement in table */ >> + /* The sort mode is adc value that increment or decrement in table */ >> enum adc_sort_mode mode; >> }; >> >> @@ -617,7 +617,7 @@ rockchip_thermal_register_sensor(struct platform_device >> *pdev, return 0; >> } >> >> -/* >> +/** >> * Reset TSADC Controller, reset all tsadc registers. >> */ >> static void rockchip_thermal_reset_controller(struct reset_control *reset) > > > > > -- > Thanks, > Caesar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/