Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbbK3Dkf (ORCPT ); Sun, 29 Nov 2015 22:40:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48157 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbbK3Dkd (ORCPT ); Sun, 29 Nov 2015 22:40:33 -0500 Date: Sun, 29 Nov 2015 22:40:31 -0500 (EST) Message-Id: <20151129.224031.1377764944004812313.davem@davemloft.net> To: anuplimbu14@gmail.com Cc: mjg59@srcf.ucam.org, tklauser@distanz.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: usb: ch9200: use kmemdup instead of kmalloc + memcpy From: David Miller In-Reply-To: <1448446041-15663-1-git-send-email-anuplimbu14@gmail.com> References: <1448446041-15663-1-git-send-email-anuplimbu14@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 29 Nov 2015 19:40:33 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 18 From: Anup Limbu Date: Wed, 25 Nov 2015 15:37:21 +0530 > replace kmalloc + memset with kmemdup > > Signed-off-by: Anup Limbu I agree with Bjorn that this microturfing cleanup misses the real higher level opportunity to use the usbnet_read_cmd() and usbnet_write_cmd() helpers that already exist. Over time I am getting more and more weary of laser focused microscopic cleanups. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/