Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 2 Mar 2003 23:17:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 2 Mar 2003 23:17:18 -0500 Received: from holomorphy.com ([66.224.33.161]:36497 "EHLO holomorphy") by vger.kernel.org with ESMTP id ; Sun, 2 Mar 2003 23:17:18 -0500 Date: Sun, 2 Mar 2003 20:27:25 -0800 From: William Lee Irwin III To: Zwane Mwaikambo Cc: Linux Kernel Subject: Re: [PATCH][2.5][CHECKER] rtc locking Message-ID: <20030303042725.GN1195@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Zwane Mwaikambo , Linux Kernel References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.25i Organization: The Domain of Holomorphy Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 535 Lines: 16 On Sun, Mar 02, 2003 at 11:19:57PM -0500, Zwane Mwaikambo wrote: > Index: linux-2.5.62-numaq/drivers/char/rtc.c [... good patch] Do you think some kind of API safety (e.g. removing *_lock_irq() in favor of *_lock_irqsave()) would be worthwhile for catching these kinds of errors? -- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/