Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbbK3G2n (ORCPT ); Mon, 30 Nov 2015 01:28:43 -0500 Received: from mail-ig0-f180.google.com ([209.85.213.180]:37571 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbbK3G2l (ORCPT ); Mon, 30 Nov 2015 01:28:41 -0500 MIME-Version: 1.0 In-Reply-To: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com> References: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com> Date: Mon, 30 Nov 2015 11:58:40 +0530 Message-ID: Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap From: Saurabh Sengar To: mathias.nyman@intel.com, Greg KH , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Sengar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 41 pinging in case this patch is lost. On 6 November 2015 at 17:46, Saurabh Sengar wrote: > added iounmap inorder to free memory mapped to base before returning > > Signed-off-by: Saurabh Sengar > --- > drivers/usb/host/pci-quirks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c > index f940056..332f687 100644 > --- a/drivers/usb/host/pci-quirks.c > +++ b/drivers/usb/host/pci-quirks.c > @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) > /* We're reading garbage from the controller */ > dev_warn(&pdev->dev, > "xHCI controller failing to respond"); > - return; > + goto iounmap; > } > > if (!ext_cap_offset) > @@ -1061,7 +1061,7 @@ hc_init: > "xHCI HW did not halt within %d usec status = 0x%x\n", > XHCI_MAX_HALT_USEC, val); > } > - > +iounmap: > iounmap(base); > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/