Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbbK3Grz (ORCPT ); Mon, 30 Nov 2015 01:47:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:55118 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598AbbK3Grx (ORCPT ); Mon, 30 Nov 2015 01:47:53 -0500 Message-ID: <565BF117.4090405@suse.de> Date: Mon, 30 Nov 2015 07:47:51 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Markus Trippelsdorf , Mike Snitzer CC: Jens Axboe , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig , "Martin K. Petersen" , Ewan Milne , Jeff Moyer Subject: Re: block: Always check queue limits for cloned requests References: <1448524017-130967-1-git-send-email-hare@suse.de> <20151126131104.GA24297@redhat.com> <20151129114956.GA321@x4> <565B1D2A.5010603@suse.de> <20151129161532.GA302@x4> <20151129164947.GA15021@redhat.com> <20151129170506.GB302@x4> In-Reply-To: <20151129170506.GB302@x4> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2755 Lines: 69 On 11/29/2015 06:05 PM, Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: >> On Sun, Nov 29 2015 at 11:15am -0500, >> Markus Trippelsdorf wrote: >> >>> On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: >>>> On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: >>>>> >>>>> I'm still seeing the issue (BUG at drivers/scsi/scsi_lib.c:1096!) even >>>>> with this patch applied. >>>>> >>>>> markus@x4 linux % git describe >>>>> v4.4-rc2-215-g081f3698e606 >>>>> >>>> Can you generate a crashdump? >>>> I would need to cross-check with the other dumps I'm having to figure >>>> out if this really is the same issue. >>>> There have been other reports (and fixes) which show we're fighting >>>> several distinct issues here. >>> >>> Unfortunately no. The crash happens on the disk where I store my log >>> files. And after it happened the magic SysRq keys don't work anymore. >>> >>> The crash only happens on my spinning rust drive that uses the cfq >>> scheduler. The SSDs (deadline) are fine. >>> >>> The BUG happens reproducibly when building http://www.sagemath.org/ on >>> that drive. >> >> Are you using DM multipath? If unsure, please let us know which >> device(s) map to the "spinning rust drive", and provide output from: >> lsblk > > No, I'm not using DM multipath. > > /dev/sdb2 on /var type btrfs (rw,relatime,compress=lzo,noacl,space_cache) > /dev/sdb2 btrfs 1.9T 904G 944G 49% /var > > scsi 1:0:0:0: Direct-Access ATA ST2000DM001-1CH1 CC29 PQ: 0 ANSI: 5 > sd 1:0:0:0: [sdb] 3907029168 512-byte logical blocks: (2.00 TB/1.81 TiB) > sd 1:0:0:0: [sdb] 4096-byte physical blocks > sd 1:0:0:0: [sdb] Write Protect is off > sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00 > sd 1:0:0:0: Attached scsi generic sg1 type 0 > sd 1:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA > > Model Family: Seagate Barracuda 7200.14 (AF) > Device Model: ST2000DM001-1CH164 > As Ming Lei indicated, this is probably a different issue. My patch is for fixing multipath-failover induced I/O errors only. So if you're not using multipath you won't be affected, neither by the original issue triggering the BUG_ON nor my patch attempting to fix it. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/