Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730AbbK3Igd (ORCPT ); Mon, 30 Nov 2015 03:36:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:60677 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753160AbbK3Igb (ORCPT ); Mon, 30 Nov 2015 03:36:31 -0500 Subject: Re: [PATCH 1/2] kbuild: add AFLAGS_REMOVE_(basename).o option To: Heiko Carstens , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Schwidefsky References: <1448103599-6660-1-git-send-email-heiko.carstens@de.ibm.com> <1448103599-6660-2-git-send-email-heiko.carstens@de.ibm.com> <20151130081708.GA4045@osiris> From: Michal Marek Message-ID: <565C0A8D.2010900@suse.com> Date: Mon, 30 Nov 2015 09:36:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151130081708.GA4045@osiris> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1966 Lines: 47 On 2015-11-30 09:17, Heiko Carstens wrote: > On Sat, Nov 21, 2015 at 11:59:58AM +0100, Heiko Carstens wrote: >> It is already possible to remove CFLAGS with the CFLAGS_REMOVE option >> that was introduced with commit 656ee82cc855 ("kbuild: create new >> CFLAGS_REMOVE_(basename).o option"). However it is not possible to >> remove AFLAGS for assembler files. >> >> So this patch just adds the AFLAGS_REMOVE option which works the same >> like CFLAGS_REMOVE. >> >> Signed-off-by: Heiko Carstens >> --- >> scripts/Makefile.lib | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib >> index 79e86613712f..26a48d76eb9d 100644 >> --- a/scripts/Makefile.lib >> +++ b/scripts/Makefile.lib >> @@ -104,8 +104,9 @@ modname_flags = $(if $(filter 1,$(words $(modname))),\ >> orig_c_flags = $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS) $(KBUILD_SUBDIR_CCFLAGS) \ >> $(ccflags-y) $(CFLAGS_$(basetarget).o) >> _c_flags = $(filter-out $(CFLAGS_REMOVE_$(basetarget).o), $(orig_c_flags)) >> -_a_flags = $(KBUILD_CPPFLAGS) $(KBUILD_AFLAGS) $(KBUILD_SUBDIR_ASFLAGS) \ >> +orig_a_flags = $(KBUILD_CPPFLAGS) $(KBUILD_AFLAGS) $(KBUILD_SUBDIR_ASFLAGS) \ >> $(asflags-y) $(AFLAGS_$(basetarget).o) >> +_a_flags = $(filter-out $(AFLAGS_REMOVE_$(basetarget).o), $(orig_a_flags)) >> _cpp_flags = $(KBUILD_CPPFLAGS) $(cppflags-y) $(CPPFLAGS_$(@F)) >> >> # > > Hello Michal, > > since I didn't hear anything from you, I'll simply add this to the s390 tree. > The patch should be trivial enough and is certainly not controversial. Hi Heiko, yes, please go ahead, the patch is fine. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/