Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638AbbK3IrG (ORCPT ); Mon, 30 Nov 2015 03:47:06 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:32914 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbbK3IrD (ORCPT ); Mon, 30 Nov 2015 03:47:03 -0500 MIME-Version: 1.0 In-Reply-To: <5199877.GVYeflqET9@wuerfel> References: <5199877.GVYeflqET9@wuerfel> Date: Mon, 30 Nov 2015 09:47:03 +0100 Message-ID: Subject: Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource From: Linus Walleij To: Arnd Bergmann Cc: "linux-gpio@vger.kernel.org" , Ludovic Desroches , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 28 On Wed, Nov 18, 2015 at 4:21 PM, Arnd Bergmann wrote: > resource_size_t may be defined as 32 or 64 bit depending on configuration, > so it cannot be printed using the normal format strings, as gcc correctly > warns: > > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': > pinctrl-at91-pio4.c:1003:41: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] > dev_dbg(dev, "bank %i: hwirq=%u\n", i, res->start); > > This changes the format string to use the special "%pr" format > string that prints a resource, and changes the arguments so we > the resource structure directly. > > Signed-off-by: Arnd Bergmann > --- > v2: don't break ordering of arguments, that part was correct already, unlike > what I said in v1. Patch applied with Ludovic's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/