Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbbK3JAE (ORCPT ); Mon, 30 Nov 2015 04:00:04 -0500 Received: from mga09.intel.com ([134.134.136.24]:8585 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbbK3JAB (ORCPT ); Mon, 30 Nov 2015 04:00:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,364,1444719600"; d="scan'208";a="609814882" Message-ID: <565C1146.3000103@intel.com> Date: Mon, 30 Nov 2015 11:05:10 +0200 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Saurabh Sengar , Greg KH , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap References: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 46 On 30.11.2015 08:28, Saurabh Sengar wrote: > pinging in case this patch is lost. > > > On 6 November 2015 at 17:46, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> drivers/usb/host/pci-quirks.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> index f940056..332f687 100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ b/drivers/usb/host/pci-quirks.c >> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> /* We're reading garbage from the controller */ >> dev_warn(&pdev->dev, >> "xHCI controller failing to respond"); >> - return; >> + goto iounmap; >> } >> >> if (!ext_cap_offset) >> @@ -1061,7 +1061,7 @@ hc_init: >> "xHCI HW did not halt within %d usec status = 0x%x\n", >> XHCI_MAX_HALT_USEC, val); >> } >> - >> +iounmap: >> iounmap(base); >> } >> >> -- >> 1.9.1 >> Thanks, I'll add it send it forward soon -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/