Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753209AbbK3LXC (ORCPT ); Mon, 30 Nov 2015 06:23:02 -0500 Received: from www.linutronix.de ([62.245.132.108]:50821 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbbK3LXA (ORCPT ); Mon, 30 Nov 2015 06:23:00 -0500 Date: Mon, 30 Nov 2015 12:22:15 +0100 (CET) From: Thomas Gleixner To: Qais Yousef cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, jiang.liu@linux.intel.com, ralf@linux-mips.org, linux-mips@linux-mips.org Subject: Re: [PATCH v2 09/19] genirq: Add a new function to get IPI reverse mapping In-Reply-To: <565C2ABD.5030409@imgtec.com> Message-ID: References: <1448453217-3874-1-git-send-email-qais.yousef@imgtec.com> <1448453217-3874-10-git-send-email-qais.yousef@imgtec.com> <5658429D.3000105@imgtec.com> <565C2ABD.5030409@imgtec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 30 On Mon, 30 Nov 2015, Qais Yousef wrote: > On 11/30/2015 10:40 AM, Thomas Gleixner wrote: > > On Fri, 27 Nov 2015, Qais Yousef wrote: > > > While trying to get my remoteproc driver work with this I uncovered a > > > problem > > > with this approach. > > > > > > mips-gic doesn't store the actual hwirq in the irq_data. It uses > > > GIC_SHARED_TO_HWIRQ() and GIC_HWIRQ_TO_SHARED() to add and remove an > > > offset. > > Why can't MIPS store the real hwirq number in irq_data? > > > I'm wary of ending up in inconsistency hell where some functions need to deal > with raw hwirq and others with translated ones. > > I will give this a go first and see if it gets really ugly. Well, the question is why can't those functions not all use the raw hardware irq. We have it in irq_data exactly to avoid calculations in the hot path functions. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/