Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753705AbbK3MIT (ORCPT ); Mon, 30 Nov 2015 07:08:19 -0500 Received: from mail-ob0-f178.google.com ([209.85.214.178]:33853 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbbK3MIR (ORCPT ); Mon, 30 Nov 2015 07:08:17 -0500 MIME-Version: 1.0 In-Reply-To: References: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com> Date: Mon, 30 Nov 2015 13:08:16 +0100 Message-ID: Subject: Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference From: Linus Walleij To: Geert Uytterhoeven Cc: LABBE Corentin , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 23 On Fri, Nov 20, 2015 at 10:22 AM, Geert Uytterhoeven wrote: > On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin > wrote: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later at line 132: >> priv->flags = (uintptr_t) of_id->data; >> >> Reported-by: coverity (CID 1324141) > > This is a DT-only driver, hence this cannot happen? Yeah I said the same in comment to some other patch in the series. But it doesn't hurt much either. Coccinelle has no clue about deeper semantics, just shallow semantics. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/