Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753948AbbK3MzW (ORCPT ); Mon, 30 Nov 2015 07:55:22 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34451 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275AbbK3MzU (ORCPT ); Mon, 30 Nov 2015 07:55:20 -0500 MIME-Version: 1.0 In-Reply-To: <1448055950-21190-1-git-send-email-leoli@freescale.com> References: <1448055950-21190-1-git-send-email-leoli@freescale.com> Date: Mon, 30 Nov 2015 13:55:19 +0100 Message-ID: Subject: Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional From: Linus Walleij To: Li Yang Cc: Wolfram Sang , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , "linux-gpio@vger.kernel.org" , Gao Pan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 21 On Fri, Nov 20, 2015 at 10:45 PM, Li Yang wrote: > - if (IS_ERR(i2c_imx->pinctrl)) { > + /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */ > + if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM || > + PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) { This is one of the evils of deferred probe: you never know if something will eventually turn up. It feels wrong to bail out on deferred probe... I have no better idea though. Acked-by Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/