Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188AbbK3Nme (ORCPT ); Mon, 30 Nov 2015 08:42:34 -0500 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:41539 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753973AbbK3Nmb (ORCPT ); Mon, 30 Nov 2015 08:42:31 -0500 Date: Mon, 30 Nov 2015 21:07:42 +0800 From: Jisheng Zhang To: Sebastian Hesselbarth CC: , , , , , , , , Subject: Re: [PATCH] arm: dts: berlin2q-marvell-dmp: add sdhci1 fully functionality Message-ID: <20151130210742.2c18adb1@xhacker> In-Reply-To: <56598DE1.9010209@gmail.com> References: <1448543588-1021-1-git-send-email-jszhang@marvell.com> <56598DE1.9010209@gmail.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-11-30_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511300246 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2697 Lines: 89 On Sat, 28 Nov 2015 12:20:01 +0100 Sebastian Hesselbarth wrote: > On 26.11.2015 14:13, Jisheng Zhang wrote: > > The sdhci1 on Marvell BG2Q DMP board is used as sdcard interface, we > > have gpios for card detection, write-protect, vqmmc and vmmc. > > > > This patch adds pinmux for this sdcard interface, then adds regulators > > for vmmc and vqmmc, lastly adds cd-gpios, wp-gpios properties. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 43 ++++++++++++++++++++++++++++-- > > 1 file changed, 41 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > > index cdcf89b..1fdc1d7 100644 > > --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > > +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > > @@ -84,12 +84,51 @@ > > gpio = <&portb 12 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > }; > > + > > + reg_sdio1_vmmc: regulator@3 { > > + compatible = "regulator-fixed"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-name = "sdio1_vmmc"; > > + enable-active-high; > > + regulator-boot-on; > > + gpio = <&portb 21 GPIO_ACTIVE_HIGH>; > > + }; > > + > > + reg_sdio1_vqmmc: regulator@4 { > > + compatible = "regulator-gpio"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-name = "sdio1_vqmmc"; > > + regulator-type = "voltage"; > > + enable-active-high; > > + gpios = <&portb 16 GPIO_ACTIVE_HIGH>; > > + states = <3300000 0x1 > > + 1800000 0x0>; > > + }; > > + }; > > +}; > > + > > +&soc_pinctrl { > > + sd1gpio_pmux: sd1pwr-pmux { > > + groups = "G23", "G32"; > > + function = "gpio"; > > + }; > > + > > + sd1_pmux: sd1-pmux { > > + groups = "G31"; > > + function = "sd1"; > > Jisheng, > > while having the sd1gpio_pmux in the board file, I think the > sd1_pmux is best kept in the SoC.dtsi. Indeed, there's no other usage with sd1's pinmux. will do in v2 > > > }; > > }; > > > > &sdhci1 { > > - broken-cd; > > - sdhci,wp-inverted; > > + vmmc-supply = <®_sdio1_vmmc>; > > + vqmmc-supply = <®_sdio1_vqmmc>; > > + cd-inverted; > > + cd-gpios = <&portc 30 GPIO_ACTIVE_HIGH>; > > How about removing cd-inverted and make cd-gpio GPIO_ACTIVE_LOW > instead? Good idea! Will do in v2. Thanks for your review, Jisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/