Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbbK3OcQ (ORCPT ); Mon, 30 Nov 2015 09:32:16 -0500 Received: from lists.s-osg.org ([54.187.51.154]:40569 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539AbbK3OcP (ORCPT ); Mon, 30 Nov 2015 09:32:15 -0500 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: vinholikatti@gmail.com, JBottomley@odin.com, jthumshirn@suse.de, linux-scsi@vger.kernel.org, akpm@linux-foundation.org, Luis de Bethencourt Subject: [RESEND] scsi: mvsas: fix misleading indentation Date: Mon, 30 Nov 2015 14:32:17 +0000 Message-Id: <1448893937-5252-1-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 48 Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended? The code is correct, the indention is misleading. When the device is not ready we want to return SAS_PHY_DOWN. But current indentation makes it look like we only do so in the else branch of if (mvi_dev). Signed-off-by: Luis de Bethencourt Reviewed-by: Johannes Thumshirn --- Hi, This is a resend of a patch from October 19th [0] Adding Andrew Morton to the CC list, as recommended at Korea Linux Forum. Thanks, Luis [0] https://lkml.org/lkml/2015/10/19/775 drivers/scsi/mvsas/mv_sas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c index 9c78074..e712fe7 100644 --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c @@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf mv_dprintk("device %016llx not ready.\n", SAS_ADDR(dev->sas_addr)); - rc = SAS_PHY_DOWN; - return rc; + rc = SAS_PHY_DOWN; + return rc; } tei.port = dev->port->lldd_port; if (tei.port && !tei.port->port_attached && !tmf) { -- 2.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/