DomainKey-Signature: a=rsa-sha1; c=nofws; d=variantweb.net; s=smtp;
 q=dns; h=Sender: Date: From: To: Cc: Subject: Message-ID: References:
 MIME-Version: Content-Type: In-Reply-To;
 b=er1aKZPyuH6gNgPwfqI7BEuv76lLi2ihY+9Z7ltghEbP0mUwspneh/jC1CerZ0ZfxQisVR
 ID4V66GRuIX8UbM4+fsEZ2MPSqt0bXY0MbzUc8oYQpz1ap+6+/u+ua/YahnkQgmoVveJnVNC
 rUiMYGSJFpcVrrtLcdESeTPN3IPg4=
Date: Mon, 30 Nov 2015 10:48:17 -0600
From: Seth Jennings <sjennings@variantweb.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Peter Anvin <hpa@zytor.com>, Daniel J Blueman <daniel@numascale.com>,
        Yinghai Lu <yinghai@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] x86: mm: clean up probe_memory_block_size()
Message-ID: <20151130164817.GA18972@cerebellum.local.variantweb.net>
References: <1448591809-10369-1-git-send-email-sjennings@variantweb.net>
 <20151127073932.GB6234@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151127073932.GB6234@gmail.com>
User-Agent: Mutt/1.5.23 (2015-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1509
Lines: 43

On Fri, Nov 27, 2015 at 08:39:32AM +0100, Ingo Molnar wrote:
> 
> * Seth Jennings <sjennings@variantweb.net> wrote:
> 
> > v2:
> > remove local bz variable (Ingo) and debug message since, if
> > the 2GB message doesn't print, there is only one possible
> > block size.
> 
> I'd not remove the info message, it would print the memory block size regardless 
> of memory size. Yes, one could decode the 'no message' case as 'the kernel used 
> the default value' - but that's very version dependent and obscure in any case. 
> Please keep the debug message in both code paths, like the original code had it.
> 
> But, on a second thought, I'd definitely harmonize the messages, instead of:
> 
> >  		pr_info("Using 2GB memory block size for large-memory system\n");
> > 	printk(KERN_DEBUG "memory block size : %ldMB\n", bz >> 20);
> 
> I'd print:
> 
> >  		pr_info("x86/mm: Memory block size: 2GB, large-memory system\n");
> > 	pr_info("x86/mm: Memory block size: %ldMB\n", bz >> 20);
> 
> Also note how I changed both printouts to pr_info(), so that we have the memory 
> block size information printed unconditionally.
> 
> (And btw., doing this printout means that we should keep the 'bz' local variable.)

Just sent out v3.

Thanks,
Seth

> 
> Thanks,
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/