Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754618AbbK3SiD (ORCPT ); Mon, 30 Nov 2015 13:38:03 -0500 Received: from h2.hallyn.com ([78.46.35.8]:45708 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbbK3SiA (ORCPT ); Mon, 30 Nov 2015 13:38:00 -0500 Date: Mon, 30 Nov 2015 12:37:58 -0600 From: "Serge E. Hallyn" To: Tejun Heo Cc: "Serge E. Hallyn" , serge@hallyn.com, linux-kernel@vger.kernel.org, adityakali@google.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, lxc-devel@lists.linuxcontainers.org, akpm@linux-foundation.org, ebiederm@xmission.com Subject: Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Message-ID: <20151130183758.GA25433@mail.hallyn.com> References: <1447703505-29672-1-git-send-email-serge@hallyn.com> <1447703505-29672-2-git-send-email-serge@hallyn.com> <20151124161630.GL17033@mtj.duckdns.org> <20151127052511.GA25490@mail.hallyn.com> <20151130151147.GG3535@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151130151147.GG3535@mtj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 35 On Mon, Nov 30, 2015 at 10:11:47AM -0500, Tejun Heo wrote: > Hello, > > On Thu, Nov 26, 2015 at 11:25:11PM -0600, Serge E. Hallyn wrote: > > > > + /* Short-circuit the easy case - kn_to is the root node. */ > > > > + if ((kn_from == kn_to) || (!kn_from && !kn_to->parent)) { > > > > + *p = '/'; > > > > + *(p + 1) = '\0'; > > > > > > Hmm... so if kn_from == kn_to, the output is "/"? > > > > Yes, that's what seems to make the most sense for cgroup namespaces. I > > could see a case for '.' being used instead in general, but for cgroup > > namespaces I think we'd have to convert those back to '/'. Otherwise > > we'll fail in being able to run legacy software, which would get > > confused. > > Yeah, I agree but the name is kinda misleading tho. The output isn't > really a relative path but rather absolute path against the specified > root. Maybe updating the function and parameter names would be > helpful? > > Thanks. Ok - updating the comment is simple enough. Though the name/params kernfs_path_from_node_locked(from, to) still seem to make sense. Would you prefer something like kernfs_absolute_path_from node_locked()? I hesitate to call 'from' 'root' since kernfs_root is a thing and this is not that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/