Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbbK3S5t (ORCPT ); Mon, 30 Nov 2015 13:57:49 -0500 Received: from mail.kernel.org ([198.145.29.136]:51084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753990AbbK3S5r (ORCPT ); Mon, 30 Nov 2015 13:57:47 -0500 Date: Mon, 30 Nov 2015 12:57:42 -0600 From: Rob Herring To: Paul Burton Cc: linux-mips@linux-mips.org, Tejun Heo , Joe Perches , Jiri Slaby , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Kumar Gala , "David S. Miller" , Ian Campbell , devicetree@vger.kernel.org, Andrew Morton , Pawel Moll , Greg Kroah-Hartman , Mark Rutland Subject: Re: [PATCH 02/28] dt-bindings: ascii-lcd: Document a binding for simple ASCII LCDs Message-ID: <20151130185742.GA28127@rob-hp-laptop> References: <1448900513-20856-1-git-send-email-paul.burton@imgtec.com> <1448900513-20856-3-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448900513-20856-3-git-send-email-paul.burton@imgtec.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2180 Lines: 63 On Mon, Nov 30, 2015 at 04:21:27PM +0000, Paul Burton wrote: > Add documentation for a devicetree binding for simple memory-mapped > ASCII LCD displays, such as those found on the Imagination Technologies > Boston & Malta development boards. > > Signed-off-by: Paul Burton > --- > > Documentation/devicetree/bindings/ascii-lcd.txt | 10 ++++++++++ This should go under bindings/display/. > MAINTAINERS | 5 +++++ > 2 files changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ascii-lcd.txt > > diff --git a/Documentation/devicetree/bindings/ascii-lcd.txt b/Documentation/devicetree/bindings/ascii-lcd.txt > new file mode 100644 > index 0000000..40ae536 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ascii-lcd.txt > @@ -0,0 +1,10 @@ > +Binding for simple memory-mapped ASCII LCD displays Presumably, this is a binding for the controller, not the actual display. You need to more fully describe what the h/w looks like here. Like what is the interface between the controller and display? Rob > + > +Required properties: > +- compatible : should be one of: > + "img,boston-lcd" > + "mti,malta-lcd" > +- reg : memory region locating the device registers > + > +The layout of the registers & properties of the display are determined > +from the compatible string, making this binding somewhat trivial. > diff --git a/MAINTAINERS b/MAINTAINERS > index cba790b..1e2b74b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1782,6 +1782,11 @@ S: Maintained > F: Documentation/hwmon/asc7621 > F: drivers/hwmon/asc7621.c > > +ASCII LCD DRIVER > +M: Paul Burton > +S: Maintained > +F: Documentation/devicetree/bindings/ascii-lcd.txt > + > ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS > M: Corentin Chary > L: acpi4asus-user@lists.sourceforge.net > -- > 2.6.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/