Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754671AbbK3TGR (ORCPT ); Mon, 30 Nov 2015 14:06:17 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:33047 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754302AbbK3TGP (ORCPT ); Mon, 30 Nov 2015 14:06:15 -0500 MIME-Version: 1.0 X-Originating-IP: [181.120.163.21] In-Reply-To: <1448897346-17780-2-git-send-email-maxime.ripard@free-electrons.com> References: <1448897346-17780-1-git-send-email-maxime.ripard@free-electrons.com> <1448897346-17780-2-git-send-email-maxime.ripard@free-electrons.com> Date: Mon, 30 Nov 2015 16:06:14 -0300 Message-ID: Subject: Re: [PATCH 1/2] regulator: Add coupled regulator From: Javier Martinez Canillas To: Maxime Ripard Cc: Mark Brown , Chen-Yu Tsai , Liam Girdwood , "devicetree@vger.kernel.org" , Linux Kernel , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 33 Hello Maxime, On Mon, Nov 30, 2015 at 12:29 PM, Maxime Ripard wrote: [snip] > > +config REGULATOR_COUPLED_VOLTAGE Shouldn't this depend on OF? > + tristate "Coupled voltage regulator support" the Kconfig symbol is tristate so the driver can be built as a module... > + > +static struct of_device_id coupled_regulator_of_match[] = { > + { .compatible = "coupled-voltage-regulator" }, > + { /* Sentinel */ }, > +}; > + ...but the driver is missing a MODULE_DEVICE_TABLE(of, ...) so module autoloading won't work. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/