Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754644AbbK3TvE (ORCPT ); Mon, 30 Nov 2015 14:51:04 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:33042 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbbK3TvC (ORCPT ); Mon, 30 Nov 2015 14:51:02 -0500 Date: Mon, 30 Nov 2015 14:50:57 -0500 (EST) Message-Id: <20151130.145057.216796732457000987.davem@davemloft.net> To: salil.mehta@huawei.com Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, paul.gortmaker@windriver.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de, liguozhu@hisilicon.com, yisen.zhuang@huawei.com, dingtianhong@huawei.com, zhangfei.gao@linaro.org, huangdaode@hisilicon.com, kenneth-lee-2012@foxmail.com, mehta.salil.lnk@gmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linuxarm@huawei.com, yankejian@huawei.com, lipeng321@huawei.com, fengguang.wu@intel.com Subject: Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem From: David Miller In-Reply-To: <1448522050-5576-2-git-send-email-salil.mehta@huawei.com> References: <1448522050-5576-1-git-send-email-salil.mehta@huawei.com> <1448522050-5576-2-git-send-email-salil.mehta@huawei.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 30 Nov 2015 11:51:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 23 From: Salil Mehta Date: Thu, 26 Nov 2015 07:14:06 +0000 > -#define ENABLE (0x1) > -#define DISABLE (0x0) > +#define ENABLE 0x1 > +#define DISABLE 0x0 Defining such common macros names for such incredibly simple boolean values is asking for trouble, in particular it can possibly collide with other defines in the global namespace. Use "true", "false", and the "bool" type, because that is exactly how you are using these values. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/