Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133AbbK3URe (ORCPT ); Mon, 30 Nov 2015 15:17:34 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35526 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbbK3URc (ORCPT ); Mon, 30 Nov 2015 15:17:32 -0500 Date: Mon, 30 Nov 2015 12:17:29 -0800 From: Brian Norris To: Boris Brezillon Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mtd: nand: fix ONFI parameter page layout Message-ID: <20151130201729.GK64635@google.com> References: <1448274187-22174-1-git-send-email-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448274187-22174-1-git-send-email-boris.brezillon@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 48 On Mon, Nov 23, 2015 at 11:23:07AM +0100, Boris Brezillon wrote: > src_ssync_features field is only 1 byte large, and the 4th reserved area > is actually 8 bytes large. > > Signed-off-by: Boris Brezillon > Fixes d1e1f4e42b5 ("mtd: nand: add support for reading ONFI parameters from NAND device") > Cc: #v2.6.37+ Did you see an actual problem from this? (And is this deserving of stable?) I could imagine an out-of-tree driver might try to use t_ald (which should actually be t_adl, right?) and get the wrong value. But no one does that in-tree yet. > --- > include/linux/mtd/nand.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index 5a9d1d4..93fc372 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -276,7 +276,7 @@ struct nand_onfi_params { > __le16 t_r; > __le16 t_ccs; > __le16 src_sync_timing_mode; > - __le16 src_ssync_features; > + u8 src_ssync_features; > __le16 clk_pin_capacitance_typ; > __le16 io_pin_capacitance_typ; > __le16 input_pin_capacitance_typ; > @@ -284,7 +284,7 @@ struct nand_onfi_params { > u8 driver_strength_support; > __le16 t_int_r; > __le16 t_ald; > - u8 reserved4[7]; > + u8 reserved4[8]; > > /* vendor */ > __le16 vendor_revision; Patch looks good. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/