Message-ID: <565CB7DD.6010003@hpe.com>
Date: Mon, 30 Nov 2015 15:55:57 -0500
From: Waiman Long <waiman.long@hpe.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12
MIME-Version: 1.0
To: Ling Ma <ling.ma.program@gmail.com>
CC: Peter Zijlstra <peterz@infradead.org>, mingo@redhat.com,
        linux-kernel@vger.kernel.org, Ling <ling.ml@alibaba-inc.com>
Subject: Re: Improve spinlock performance by moving work to one core
References: <CAOGi=dN6=iHUKyN=BcJ4dZkEyv5bA9amU1uCqD-hqaUJnY=Zug@mail.gmail.com> <563B8E85.6090104@hpe.com> <CAOGi=dPc0mpzVKiFKFrgi3qw6RSLaMpO5ZoKEY-7HjcAMHLMhg@mail.gmail.com> <563CE5A6.8080409@hpe.com> <CAOGi=dOLCQ4BtzpsSEO-XVepFbypvj7qJ4_d2=bcp4KYRKJ5RQ@mail.gmail.com> <56560691.8000702@hpe.com> <CAOGi=dPLk1HdpnZUq=BqH=sw5xaQ79WWaywuyfzwb1t04JiRuA@mail.gmail.com> <CAOGi=dPsyn4i_Y9VvZOc=8Et=8m-sqZWeqoi83VLOe6JmH3+XA@mail.gmail.com> <CAOGi=dOoPbpVcJDU+Y1wtFenUiD0QRcxoKovq9wgb4zD+qs5Hw@mail.gmail.com>
In-Reply-To: <CAOGi=dOoPbpVcJDU+Y1wtFenUiD0QRcxoKovq9wgb4zD+qs5Hw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 789
Lines: 26

On 11/30/2015 01:17 AM, Ling Ma wrote:
> Any comments, the patch is acceptable ?
>
> Thanks
> Ling
>
>
Ling,

The core idea of your current patch hasn't changed from your previous
patch.

My comment is that you should not attempt to sell it as a replacement
of the current spinlock mechanism. I just don't see that will happen
given the change in API semantics. Also, I think there are probably
cases that your patch cannot be applied. So treat it as a separate
synchronization mechanism that can be useful in some scenarios.

Cheers,
Longman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/