MIME-Version: 1.0
In-Reply-To: <1448714728-12729-1-git-send-email-razor@blackwall.org>
References: <1448714728-12729-1-git-send-email-razor@blackwall.org>
Date: Tue, 1 Dec 2015 08:48:30 +0900
Message-ID: <CAC5umyjONtF9r=Ox1-mMS-vzxp2j-fk+VX1wWWVvWvyOxWPbiQ@mail.gmail.com>
Subject: Re: [PATCH] net: add support for netdev notifier error injection
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: LKML <linux-kernel@vger.kernel.org>, shm@cumulusnetworks.com,
        gospo@cumulusnetworks.com, roopa@cumulusnetworks.com,
        dsa@cumulusnetworks.com,
        Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
        "David S. Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1152
Lines: 23

2015-11-28 21:45 GMT+09:00 Nikolay Aleksandrov <razor@blackwall.org>:
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> This module allows to insert errors in some of netdevice's notifier
> events. All network drivers use these notifiers to signal various events
> and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU
> afterwards. Until recently I had to run failure tests by injecting
> a custom module, but now this infrastructure makes it trivial to test
> these failure paths. Some of the recent bugs I fixed were found using
> this module.
> Here's an example:
>  $ cd /sys/kernel/debug/notifier-error-inject/netdev
>  $ echo -22 > actions/NETDEV_CHANGEMTU/error
>  $ ip link set eth0 mtu 1024
>  RTNETLINK answers: Invalid argument

This patch looks good to me.  It would be nice if you add tools like
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh for this feature.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/