Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755366AbbLAAcs (ORCPT ); Mon, 30 Nov 2015 19:32:48 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33318 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710AbbLAAcq (ORCPT ); Mon, 30 Nov 2015 19:32:46 -0500 Date: Tue, 1 Dec 2015 09:33:47 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: "kyeongdon.kim" , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Message-ID: <20151201003347.GA653@swordfish> References: <1448597449-17579-1-git-send-email-sergey.senozhatsky@gmail.com> <20151130071053.GB3262@bbox> <565C27FA.407@lge.com> <20151130231841.GA960@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151130231841.GA960@bbox> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 32 On (12/01/15 08:18), Minchan Kim wrote: [..] > > As you know, if there is 'null' return, this function is called again to > > get a memory in while() loop. I just checked this one with printk(). > > > > If you guys don't mind, I'll test more with trace log to check time delay. > > No problem. > > > > > However, If this is fully expectable status to you. > > I think I don't need to do it. > > It's not what I expected. Actually, I thought failure of vmalloc > in that place should be *really really* rare. I think it's caused by > __GFP_NOMEMALLOC so I want to see test result without the flag. hm, agree. otherwise the whole vmalloc() fallback thing adds a little value. additional streams are really not that important to waste emergency memory. a stream, once allocated, stays forever (until user decrease the ->max_strm). > Thanks for the careful test! yes, thank you Kyeongdon. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/