Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755481AbbLAAou (ORCPT ); Mon, 30 Nov 2015 19:44:50 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34116 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbbLAAot (ORCPT ); Mon, 30 Nov 2015 19:44:49 -0500 Date: Mon, 30 Nov 2015 16:44:46 -0800 From: Stephen Boyd To: Masahiro Yamada Cc: linux-clk@vger.kernel.org, Michael Turquette , Linux Kernel Mailing List , Ben Dooks Subject: Re: [PATCH 2/3] clk: let of_clk_get_parent_name() fail for invalid clock-indices Message-ID: <20151201004446.GC17532@codeaurora.org> References: <1448004981-11133-1-git-send-email-yamada.masahiro@socionext.com> <1448004981-11133-2-git-send-email-yamada.masahiro@socionext.com> <20151120174509.GQ32672@codeaurora.org> <20151124005324.GM19156@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 60 On 11/30, Masahiro Yamada wrote: > Hi Stephen, > > > > >> > >> Of course we can, although we have to mention "clock-indices" twice. > >> > >> A good thing for of_get_property() is that we can get both the value > >> and the length > >> at the same time. > >> > > > > Ok. Well if we don't want to count them again, perhaps a goto > > jump over an unconditional return NULL would be better? > > > > of_property_for_each_u32(clkspec.np, "clock-indices", prop, vp, pv) { > > if (index == pv) { > > index = count; > > goto found; > > } > > count++; > > } > > > > return NULL; > > found: > > > > Or since the macro for of_property_for_each_u32() tests the vp > > poitner for NULL, we can check that pointer too... > > > > of_property_for_each_u32(clkspec.np, "clock-indices", prop, vp, pv) { > > if (index == pv) { > > index = count; > > break; > > } > > count++; > > } > > > > /* We didn't find anything */ > > if (!vp) > > return NULL; > > > > I guess I prefer the latter approach here. > > > > No. > > Neither of your two suggestions works because they are false positive. > So if (!vp && count) then? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/