Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755497AbbLABKL (ORCPT ); Mon, 30 Nov 2015 20:10:11 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:33901 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbbLABKI (ORCPT ); Mon, 30 Nov 2015 20:10:08 -0500 MIME-Version: 1.0 In-Reply-To: <565CECF1.6090101@redhat.com> References: <1447892054-8095-1-git-send-email-labbott@fedoraproject.org> <565CECF1.6090101@redhat.com> Date: Mon, 30 Nov 2015 17:10:07 -0800 X-Google-Sender-Auth: uWSTnxquTLPG94Z57QPNrdQr9A8 Message-ID: Subject: Re: [PATCHv2] arm: Update all mm structures with section adjustments From: Kees Cook To: Laura Abbott Cc: Laura Abbott , Russell King , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , LKML , Linux-MM Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 54 On Mon, Nov 30, 2015 at 4:42 PM, Laura Abbott wrote: > On 11/30/2015 03:40 PM, Kees Cook wrote: >> >> On Thu, Nov 19, 2015 at 11:10 AM, Kees Cook wrote: >>> >>> On Wed, Nov 18, 2015 at 4:14 PM, Laura Abbott >>> wrote: >>>> >>>> Currently, when updating section permissions to mark areas RO >>>> or NX, the only mm updated is current->mm. This is working off >>>> the assumption that there are no additional mm structures at >>>> the time. This may not always hold true. (Example: calling >>>> modprobe early will trigger a fork/exec). Ensure all mm structres >>>> get updated with the new section information. >>>> >>>> Signed-off-by: Laura Abbott >>> >>> >>> This looks right to me. :) >>> >>> Reviewed-by: Kees Cook >>> >>> Russell, does this work for you? >> >> >> Did this end up in the patch tracker? (I just sent a patch that'll >> collide with this... I'm happy to do the fix up.) >> > > I put this in the patch tracker this morning. Ah-ha, great! I will rebase my change on to it and send a v2 (potentially with additional changes). -Kees > >> >> -Kees >> > > Thanks, > Laura -- Kees Cook Chrome OS & Brillo Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/