Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519AbbLABt7 (ORCPT ); Mon, 30 Nov 2015 20:49:59 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36634 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755348AbbLABt5 (ORCPT ); Mon, 30 Nov 2015 20:49:57 -0500 Message-ID: <565CFC7C.101@gmail.com> Date: Mon, 30 Nov 2015 17:48:44 -0800 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Paul Burton , linux-mips@linux-mips.org CC: =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= , Michal Simek , Jiang Liu , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, Russell Joyce , Arnd Bergmann , linux-kernel@vger.kernel.org, Thomas Gleixner , Jingoo Han , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 20/28] net: pch_gbe: clear interrupt FIFO during probe References: <1448900513-20856-1-git-send-email-paul.burton@imgtec.com> <1448900513-20856-21-git-send-email-paul.burton@imgtec.com> In-Reply-To: <1448900513-20856-21-git-send-email-paul.burton@imgtec.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 18 On 30/11/15 08:21, Paul Burton wrote: > xilinx_pcie_init_port clears the pending interrupts in the interrupt > decode register, but does not clear the interrupt FIFO. This would lead > to spurious interrupts if any were present in the FIFO at probe time. > Clear the interrupt FIFO prior to the interrupt decode register in order > to start with a clean slate as expected. > > Signed-off-by: Paul Burton Seems like the subject should be "PCI: xilinx: ..." to be consistent with the changes you are making to this driver earlier in the series? -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/