Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755570AbbLABwm (ORCPT ); Mon, 30 Nov 2015 20:52:42 -0500 Received: from mail-bn1bon0135.outbound.protection.outlook.com ([157.56.111.135]:28576 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755442AbbLABwk (ORCPT ); Mon, 30 Nov 2015 20:52:40 -0500 X-Greylist: delayed 86766 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Nov 2015 20:52:40 EST From: Duan Andy To: =?utf-8?B?TG90aGFyIFdhw59tYW5u?= , Andrew Lunn , "David S. Miller" , Fabio Estevam , Greg Ungerer , Kevin Hao , Lucas Stach , Philippe Reynes , Richard Cochran , Russell King , Sascha Hauer , "Stefan Agner" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Jeff Kirsher , "Uwe Kleine-K?nig" Subject: RE: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out clock Thread-Topic: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out clock Thread-Index: AQHRK2LoJjXzOYpAHkS8F/Lf0Yrt9J61XXyw Date: Tue, 1 Dec 2015 01:52:35 +0000 Message-ID: References: <1448883168-30742-1-git-send-email-LW@KARO-electronics.de> In-Reply-To: <1448883168-30742-1-git-send-email-LW@KARO-electronics.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fugang.duan@freescale.com; x-originating-ip: [123.151.195.51] x-microsoft-exchange-diagnostics: 1;BY1PR03MB1435;5:4Xe4tGON6fqqyUD/MV6cLBxos4JZhaUq4vE9uwIzNPADePRopVqSKyAcaVZwl9x/z/rLM7cnbVQ/VpQ8lPD54SdR9ZXDFmCbsmv2GfW4NOFUmzBwYV6xUWJZJb9NYkJwjenb3zJgCDF5/F0Lo9bkBQ==;24:6qsgyan7FXyUPMkbXWmNgmlItxDC/O1QL9sn739ZvhuMIBMkMuL46koxUlPv1mkqTYoNPw0EgOLyIGjdF5tK+bOiKAl9Eh5v7I+YeAhR2vU= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1435; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:BY1PR03MB1435;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1435; x-forefront-prvs: 07778E4001 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(377454003)(189002)(97736004)(3846002)(81156007)(54356999)(101416001)(105586002)(5001770100001)(87936001)(76176999)(5002640100001)(86362001)(2950100001)(102836003)(6116002)(33656002)(586003)(1096002)(2900100001)(77096005)(5008740100001)(107886002)(189998001)(10400500002)(92566002)(106116001)(50986999)(74316001)(122556002)(66066001)(5004730100002)(1220700001)(99286002)(5003600100002)(76576001)(19580405001)(40100003)(19580395003)(2201001)(2501003)(5001960100002)(106356001)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1435;H:BN3PR0301MB1219.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2015 01:52:35.7478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1435 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB11qlu5024190 Content-Length: 1474 Lines: 24 From: Lothar Waßmann Sent: Monday, November 30, 2015 7:33 PM > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer; > Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe > Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan Agner; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; Jeff Kirsher; Uwe Kleine- > König > Subject: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out > clock > > This patchset fixes a regression introduced by commit 8fff755e9f8d ("net: > fec: Ensure clocks are enabled while using mdio bus") for ethernet PHYs > that are using ENET_OUT as reference clock (on i.MX6 or i.MX28) > Do you mean commit 8fff755e9f8d cause your problem ? This commit just manage ipg clock in runtime because mdio bus can access external phy switch no matter netdev status. I don't think the commit cause phy link up/down issue. Phy link up/down is due to phy is not ready after power/clock on, it need to do reset. > The first patch is a cleanup patch that removes redundant NULL checks. > The second patch converts the driver to use the 'gpiod' framework. > The third patch makes sure, fec_reset_phy() is called whenever the > enet_out clock has been (re-)enabled to get the PHY into a > consistent state. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?