Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755521AbbLAB4R (ORCPT ); Mon, 30 Nov 2015 20:56:17 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:23367 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753276AbbLAB4P (ORCPT ); Mon, 30 Nov 2015 20:56:15 -0500 To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, vinholikatti@gmail.com, JBottomley@odin.com, jthumshirn@suse.de, linux-scsi@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [RESEND] scsi: mvsas: fix misleading indentation From: "Martin K. Petersen" Organization: Oracle Corporation References: <1448893937-5252-1-git-send-email-luisbg@osg.samsung.com> Date: Mon, 30 Nov 2015 20:55:59 -0500 In-Reply-To: <1448893937-5252-1-git-send-email-luisbg@osg.samsung.com> (Luis de Bethencourt's message of "Mon, 30 Nov 2015 14:32:17 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 21 >>>>> "Luis" == Luis de Bethencourt writes: Luis> Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 Luis> mvs_task_prep() warn: curly braces intended? Luis> The code is correct, the indention is misleading. When the device Luis> is not ready we want to return SAS_PHY_DOWN. But current Luis> indentation makes it look like we only do so in the else branch of Luis> if (mvi_dev). Applied to 4.5/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/