Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbbLABrI (ORCPT ); Mon, 30 Nov 2015 20:47:08 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:60907 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754539AbbLABrF (ORCPT ); Mon, 30 Nov 2015 20:47:05 -0500 From: "Rafael J. Wysocki" To: Graeme Gregory Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, shannon.zhao@linaro.org, Len Brown , Russell King Subject: Re: [PATCH 2/3] ACPI: scan add call to probe amba devices Date: Tue, 01 Dec 2015 03:16:53 +0100 Message-ID: <8504062.kEYB5C4QA7@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1443609530-21524-3-git-send-email-graeme.gregory@linaro.org> References: <1443609530-21524-1-git-send-email-graeme.gregory@linaro.org> <1443609530-21524-3-git-send-email-graeme.gregory@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 45 On Wednesday, September 30, 2015 11:38:49 AM Graeme Gregory wrote: > Call the amba device creation function in the default enumeration path, > this is the same location platform devices are probed. First, I'm sorry for the glacially slow response here. > Cc: Rafael J. Wysocki > Cc: Len Brown > Cc: Russell King > Signed-off-by: Graeme Gregory > --- > drivers/acpi/scan.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index f834b8c..aa3184e 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -1633,8 +1633,10 @@ static void acpi_default_enumeration(struct acpi_device *device) > acpi_dev_get_resources(device, &resource_list, acpi_check_spi_i2c_slave, > &is_spi_i2c_slave); > acpi_dev_free_resource_list(&resource_list); > - if (!is_spi_i2c_slave) > + if (!is_spi_i2c_slave) { > + acpi_create_amba_device(device); Do you really have to add this here? It would be much cleaner to use a new scan handler instead. > acpi_create_platform_device(device); > + } > } > > static const struct acpi_device_id generic_device_ids[] = { > Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/