From: Duan Andy <fugang.duan@freescale.com>
To: =?utf-8?B?TG90aGFyIFdhw59tYW5u?= <LW@KARO-electronics.de>,
        Andrew Lunn <andrew@lunn.ch>, "David S. Miller" <davem@davemloft.net>,
        Fabio Estevam <Fabio.Estevam@freescale.com>,
        Greg Ungerer <gerg@uclinux.org>, Kevin Hao <haokexin@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Philippe Reynes <tremyfr@gmail.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "Stefan Agner" <stefan@agner.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        "Uwe Kleine-K?nig" <u.kleine-koenig@pengutronix.de>
Subject: RE: [PATCH 2/3] net: fec: convert to using gpiod framework
Thread-Topic: [PATCH 2/3] net: fec: convert to using gpiod framework
Thread-Index: AQHRK2LokJokHOEc+kqISglbuVok+Z61Y3vA
Date: Tue, 1 Dec 2015 02:17:01 +0000
Message-ID: <BN3PR0301MB1219D8F59FEB74A4C445E405F50F0@BN3PR0301MB1219.namprd03.prod.outlook.com>
References: <1448883168-30742-1-git-send-email-LW@KARO-electronics.de>
 <1448883168-30742-2-git-send-email-LW@KARO-electronics.de>
 <1448883168-30742-3-git-send-email-LW@KARO-electronics.de>
In-Reply-To: <1448883168-30742-3-git-send-email-LW@KARO-electronics.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2015 02:17:01.4241
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1433
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB12W5ls024316
Content-Length: 2522
Lines: 65

From: Lothar Waßmann <LW@KARO-electronics.de> Sent: Monday, November 30, 2015 7:33 PM
> To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer;
> Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe
> Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan Agner; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org; Jeff Kirsher; Uwe Kleine-
> König
> Subject: [PATCH 2/3] net: fec: convert to using gpiod framework
> 
> Use gpiod_get_optional() instead of checking for a valid GPIO number and
> calling devm_gpio_request_one() conditionally.
> 
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index e17d74f..1a983fc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3233,7 +3233,7 @@ static int fec_enet_init(struct net_device *ndev)
> #ifdef CONFIG_OF  static void fec_reset_phy(struct platform_device *pdev)
> {
> -	int err, phy_reset;
> +	struct gpio_desc *phy_reset;
>  	int msec = 1;
>  	struct device_node *np = pdev->dev.of_node;
> 
> @@ -3245,18 +3245,15 @@ static void fec_reset_phy(struct platform_device
> *pdev)
>  	if (msec > 1000)
>  		msec = 1;
> 
> -	phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
> -	if (!gpio_is_valid(phy_reset))
> -		return;
> -
> -	err = devm_gpio_request_one(&pdev->dev, phy_reset,
> -				    GPIOF_OUT_INIT_LOW, "phy-reset");
> -	if (err) {
> -		dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n",
> err);
> +	phy_reset = devm_gpiod_get_optional(&pdev->dev, "phy-reset",
> +					    GPIOD_OUT_LOW);
> +	if (IS_ERR(phy_reset)) {
> +		dev_err(&pdev->dev, "failed to get phy-reset-gpios: %ld\n",
> +			PTR_ERR(phy_reset));
>  		return;
>  	}
>  	msleep(msec);
> -	gpio_set_value_cansleep(phy_reset, 1);
> +	gpiod_set_value_cansleep(phy_reset, 1);

This API will judge the GPIO active polarity, there many imx boards in dts files don't care the polarity.
So pls drop the patch.

Or use gpiod_set_raw_value_cansleep() instead of gpiod_set_value_cansleep().

>  }
>  #else /* CONFIG_OF */
>  static void fec_reset_phy(struct platform_device *pdev)
> --
> 2.1.4
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?