Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754274AbbLAGJe (ORCPT ); Tue, 1 Dec 2015 01:09:34 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:36952 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbbLAGJc (ORCPT ); Tue, 1 Dec 2015 01:09:32 -0500 X-Auth-Info: jImsZveoSLs41RdOZ928Omp1A24LqF3hlgRpnYr0X/0= Subject: Re: [PATCH v2] arm, am335x: add support for the bosch shc board To: Tony Lindgren References: <1447748655-2088-1-git-send-email-hs@denx.de> <20151130214130.GA23396@atomide.com> <565D2DF9.2010806@denx.de> <20151201055333.GO23396@atomide.com> Cc: linux-kernel@vger.kernel.org, =?UTF-8?Q?Beno=c3=aet_Cousson?= , Robert Nelson , devicetree@vger.kernel.org, Dave Gerlach , Georg.Soffel@bosch-si.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Brown Reply-To: hs@denx.de From: Heiko Schocher Message-ID: <565D3997.9060905@denx.de> Date: Tue, 1 Dec 2015 07:09:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20151201055333.GO23396@atomide.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4109 Lines: 136 Hello Tony, Am 01.12.2015 um 06:53 schrieb Tony Lindgren: > * Heiko Schocher [151130 21:21]: >> Hello Tony, >> >> Am 30.11.2015 um 22:41 schrieb Tony Lindgren: >>> * Heiko Schocher [151117 00:25]: >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/am335x-shc.dts >>>> +&tps { >>>> + compatible = "ti,tps65217"; >>>> + ti,pmic-shutdown-controller; >>>> + >>>> + regulators { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + dcdc1_reg: regulator@0 { >>>> + reg = <0>; >>>> + regulator-name = "vdds_dpr"; >>>> + regulator-compatible = "dcdc1"; >>>> + regulator-min-microvolt = <1300000>; >>>> + regulator-max-microvolt = <1450000>; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>>> + }; >>>> + >>>> + dcdc2_reg: regulator@1 { >>>> + reg = <1>; >>>> + /* >>>> + * VDD_MPU voltage limits 0.95V - 1.26V with >>>> + * +/-4% tolerance >>>> + */ >>>> + regulator-compatible = "dcdc2"; >>>> + regulator-name = "vdd_mpu"; >>>> + regulator-min-microvolt = <925000>; >>>> + regulator-max-microvolt = <1375000>; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>>> + regulator-ramp-delay = <70000>; >>>> + }; >>>> + >>>> + dcdc3_reg: regulator@2 { >>>> + reg = <2>; >>>> + /* >>>> + * VDD_CORE voltage limits 0.95V - 1.1V with >>>> + * +/-4% tolerance >>>> + */ >>>> + regulator-name = "vdd_core"; >>>> + regulator-compatible = "dcdc3"; >>>> + regulator-min-microvolt = <925000>; >>>> + regulator-max-microvolt = <1125000>; >>>> + regulator-boot-on; >>>> + regulator-always-on; >>>> + }; >>>> + >>>> + ldo1_reg: regulator@3 { >>>> + reg = <3>; >>>> + regulator-name = "vio,vrtc,vdds"; >>>> + regulator-compatible = "ldo1"; >>>> + regulator-min-microvolt = <1000000>; >>>> + regulator-max-microvolt = <1800000>; >>>> + regulator-always-on; >>>> + }; >>>> + >>>> + ldo2_reg: regulator@4 { >>>> + reg = <4>; >>>> + regulator-name = "vdd_3v3aux"; >>>> + regulator-compatible = "ldo2"; >>>> + regulator-min-microvolt = <900000>; >>>> + regulator-max-microvolt = <3300000>; >>>> + regulator-always-on; >>>> + }; >>>> + >>>> + ldo3_reg: regulator@5 { >>>> + reg = <5>; >>>> + regulator-name = "vdd_1v8"; >>>> + regulator-compatible = "ldo3"; >>>> + regulator-min-microvolt = <900000>; >>>> + regulator-max-microvolt = <1800000>; >>>> + regulator-always-on; >>>> + }; >>>> + >>>> + ldo4_reg: regulator@6 { >>>> + reg = <6>; >>>> + regulator-name = "vdd_3v3a"; >>>> + regulator-compatible = "ldo4"; >>>> + regulator-min-microvolt = <1800000>; >>>> + regulator-max-microvolt = <3300000>; >>>> + regulator-always-on; >>>> + }; >>>> + }; >>>> +}; >>> >>> Applying this into omap-for-v4.5/dt.. But I'm getting concerned about this >>> "regulator-always-on" stuff and having multiple copies of the same thing. >>> >>> I think we should have a common am33xx-tps65217.dtsi file that has the >>> regulators defined at one place and other then include it. And they are >>> controllable AFAIK.. >> >> Hmm... Mark Brown (added to Cc) suggested to move this regulator nodes >> into the board DT file and remove such files [1]. > > Hmm it was probably the name of that file causing confusion as it was not > am33xx specific. If we have many board variants using almost the same exact > regulators and configuration it totally makes sense to have a shared dtsi > file for them :) Ack. > It may actually be better to have it as am33xx-common.dtsi and I bet that > covers quite a few am33xx boards for the basic shared functionality. I try to find some time to make such a patch... bye, Heiko > > Regards, > > Tony > > >> [1] https://lkml.org/lkml/2015/10/21/581 > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/