From: Duan Andy <fugang.duan@freescale.com>
To: =?utf-8?B?TG90aGFyIFdhw59tYW5u?= <LW@KARO-electronics.de>
CC: Andrew Lunn <andrew@lunn.ch>, "David S. Miller" <davem@davemloft.net>,
        Fabio Estevam <Fabio.Estevam@freescale.com>,
        Greg Ungerer <gerg@uclinux.org>, Kevin Hao <haokexin@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Philippe Reynes <tremyfr@gmail.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Sascha Hauer <s.hauer@pengutronix.de>, Stefan Agner <stefan@agner.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Subject: RE: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out
 clock
Thread-Topic: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out
 clock
Thread-Index: AQHRK2LoJjXzOYpAHkS8F/Lf0Yrt9J61XXywgABeeACAAAGkcA==
Date: Tue, 1 Dec 2015 07:33:04 +0000
Message-ID: <BN3PR0301MB12197562445A211CC7F15ADBF50F0@BN3PR0301MB1219.namprd03.prod.outlook.com>
References: <1448883168-30742-1-git-send-email-LW@KARO-electronics.de>
	<BN3PR0301MB1219D0A7525EB2535856BE52F50F0@BN3PR0301MB1219.namprd03.prod.outlook.com>
 <20151201082450.6a4a9421@ipc1.ka-ro>
In-Reply-To: <20151201082450.6a4a9421@ipc1.ka-ro>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2015 07:33:04.1055
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1434
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB17XFUM025541
Content-Length: 1848
Lines: 39

From: Lothar Waßmann <LW@KARO-electronics.de> Sent: Tuesday, December 01, 2015 3:25 PM
> To: Duan Fugang-B38611
> Cc: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungerer;
> Kevin Hao; Lucas Stach; Philippe Reynes; Richard Cochran; Russell King;
> Sascha Hauer; Stefan Agner; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; Jeff Kirsher; Uwe Kleine-K?nig
> Subject: Re: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the
> enet_out clock
> 
> Hi,
> 
> > From: Lothar Waßmann <LW@KARO-electronics.de> Sent: Monday, November
> > 30, 2015 7:33 PM
> > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg
> > > Ungerer; Kevin Hao; Lothar Waßmann; Lucas Stach; Duan Fugang-B38611;
> > > Philippe Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan
> > > Agner; linux- kernel@vger.kernel.org; netdev@vger.kernel.org; Jeff
> > > Kirsher; Uwe Kleine- König
> > > Subject: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the
> > > enet_out clock
> > >
> > > This patchset fixes a regression introduced by commit 8fff755e9f8d
> ("net:
> > > fec: Ensure clocks are enabled while using mdio bus") for ethernet
> > > PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
> > >
> > Do you mean commit 8fff755e9f8d cause your problem ?  This commit just
> manage ipg clock in runtime because mdio bus can access external phy
> switch no matter netdev status.
> >
> No. Actually I meant commit e8fcfcd5684a ("net: fec: optimize the clock
> management to save power") which started to disable the clocks when not
> in use.
> 
Understand. Yes, disable enet_out clock for power saving is necessary.

> Sorry for the confusion,
> Lothar Waßmann
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?